Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove legacy flatten/from_iter APIs #1186

Merged
merged 3 commits into from
Jan 7, 2025
Merged

chore: Remove legacy flatten/from_iter APIs #1186

merged 3 commits into from
Jan 7, 2025

Conversation

zlangley
Copy link
Contributor

@zlangley zlangley commented Jan 7, 2025

No description provided.

@zlangley zlangley requested a review from jonathanpwang January 7, 2025 18:57
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@jonathanpwang jonathanpwang changed the title feat: Remove legacy flatten/from_iter APIs chore: Remove legacy flatten/from_iter APIs Jan 7, 2025
jonathanpwang
jonathanpwang approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, yay

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-50 [-3.4%]) 1,440 195,126 8,026,812 - - -
fibonacci_program (-48 [-0.7%]) 6,408 1,500,137 51,505,102 - - -
regex_program (+240 [+1.2%]) 19,724 4,190,904 165,028,173 - - -
ecrecover_program (+15 [+0.6%]) 2,625 285,169 15,074,875 - - -

Commit: 4a9d886

Benchmark Workflow

@jonathanpwang jonathanpwang merged commit a9795b3 into main Jan 7, 2025
22 checks passed
@jonathanpwang jonathanpwang deleted the feat/rm-legacy branch January 7, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zlangley @jonathanpwang